<div class="gmail_quote">2009/1/8 Ian Clatworthy <span dir="ltr"><<a href="mailto:ian.clatworthy@internode.on.net">ian.clatworthy@internode.on.net</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
...<br>
I also suspect that filtering on remote revisions will be more<br>
common than on local, </blockquote><div>100% agree<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">because pulling/merging/updating arguably<br>
happens more frequently that pushing, especially given Bazaar's<br>
bound branch support. So my suggestion is:<br>
<br>
* --revision, -r for remote revision filtering<br>
* --my-revision for this revision filtering.</blockquote><div>yes please. done.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I don't think the latter needs a shortcut.</blockquote><div>done.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Please add a NEWS entry.</blockquote><div>done.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Please expand the missing help to include filtering examples.</blockquote><div>done. (I gave it a shot but it can probably be improved)<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + # clone and add a differing revision<br>
> + b_tree = a_tree.bzrdir.sprout('b').open_workingtree()<br>
> +<br>
> + for i in range(2, 6):<br>
<br>
s/a differing revision/differing revisions/</blockquote><div>done. <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + out,err = self.run_bzr('missing ../b -r 2', retcode=1)<br>
> + self.assertMessages(out, ('a2', 'b2', 'b3', 'b4', 'b5'), ('a3',))<br>
<br>
So if just one limit is given, it's implicitly an upper one?</blockquote><div>no, it behaves like `bzr log -r 2` i.e. it will only return revision 2.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I had expected it to be the lower one with the upper limit being<br>
the last in that branch. (If I'm right, there's a bug, right?)</blockquote><div>I updated the test and missing documentation to reflect this behaviour better<br>(I borrowed some documentation from cmd_log).<br> </div>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> +<br>
> + self.assertUnmerged([], [('4', 'rev6', 0)],<br>
> + tree.branch, tree2.branch, 'all',<br>
> + include_merges=True, remote_revid_range=(rev6, rev6))<br>
<br>
You could probably drop the 'all' parameter as you've done<br>
elsewhere.</blockquote><div>I removed 'all' of them now.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + self.assertUnmerged([], [('3', 'rev3',0 ), ('3.1.1', 'rev4', 1)],<br>
<br>
add space after ,.</blockquote><div>done.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + self.assertUnmerged([], [('4', 'rev6', 0),('3.1.2', 'rev5', 1)],<br>
</blockquote><div>done.<br></div></div><br>Thanx a lot for the review!<br>-- <br><| regards<br>U| Marius<br>H| <>< <br>