<div class="gmail_quote">2009/1/18 Marius Kruger <<a href="mailto:amanic@gmail.com">amanic@gmail.com</a>> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> hi, as promised, here it is. because the bundle and full patch is so big (1.1MB), I uploaded a branch <a href="https://code.launchpad.net/%7Eamanica/bzr/code_style_cleanup" target="_blank">https://code.launchpad.net/~amanica/bzr/code_style_cleanup</a> The merge directive for bundlebuggy is with --no-bundle and --no-patch but with the public branch, hope that is ok as I've not done that before. I attached a compressed version of the full merge directive.</blockquote> <div> bundlebuggy doesnt seem to like this, so here is the big file, hope that works..  </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> For easier reviewing I also attached diffs of 1) all the non-whitespace-changes I made bzr dif --old ../bzr.dev/ --diff-options -w  > ../20090117_2357-bzr.code_style_cleanup.non-whitespace-changes.diff 2) what I did before the code cleanup. bzr dif --old ../bzr.dev/ -r ..3948 > ../2009-01/20090117_2357-bzr.code_style_cleanup.sourcetest-and-doc-updates.diff 3) what I had to do to make the tests that required some trailing white space to pass again bzr dif -c 3947.1.2 > /stuph/projects/bzr/patches/2009-01/20090117_2357-bzr.code_style_cleanup.test-fixes.diff Some notes * I moved test_coding_style in with test_no_tabs, because no-tabs is also coding style and I didn't want us to read through all the source files another time needlessly. * I added tests for other code style conventions we already comply with. * I print out the number of long lines we have. * I noted the conventions we are now testing for in HACKING. * The cleanup was straight forward using a new command in my new plugin (<a href="https://launchpad.net/bzr-text-checker" target="_blank">https://launchpad.net/bzr-text-checker</a>)    bzr$ bzr remove-trailing-whitespace bzr    bzr/bzrlib$ bzr remove-trailing-whitespace *.py * we only test bzr and bzrlib, ie not stuff in contrib, tools, NEWS, etc. I think we can add and clean them later if we wish to. -- <| regards U| Marius H| <>< </blockquote></div>