2008/12/8 Martin Pool <span dir="ltr"><<a href="mailto:mbp@canonical.com">mbp@canonical.com</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Sun, Jul 27, 2008 at 6:19 AM, John Arbash Meinel<br>
<<a href="mailto:john@arbash-meinel.com">john@arbash-meinel.com</a>> wrote:<br>
> -----BEGIN PGP SIGNED MESSAGE-----<br>
> Hash: SHA1<br>
><br>
> Marius Kruger wrote:<br>
> | Thats right folks,<br>
> | I think I've successfully written a test which checks for bazaar code<br>
> | style regressions in the not-yet-commited changes of the working tree<br>
> | being tested.<br>
> | Currently I check all newly modified .py files for:<br>
> | * new trailing white space<br>
> | * new leading tabs<br>
> | * new long lines (give warning only)<br>
> | * no newline at end of files<br>
> |<br>
> | It already came in usefull while preparing this patch<br>
> | ./bzr --no-plugins selftest coding_style<br>
> | will help people like me to easily prepare non-style-regressing patches.<br>
<br>
</div>That's pretty cool.</blockquote><div>yeay<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Like John, I think I'd prefer this be done in test_source </blockquote><div>thats done in the latest patch<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
and check<br>
the whole working tree, except for things that are specifically<br>
excluded, such as copied-in library source. Then there's no chance of<br>
missing things that are committed without checking them. If there are<br>
already things that would fail, let's just fix them up.</blockquote><div><br></div></div>Uhm, last time I checked, the bazaar source is riddled with trailing white space, try:<br>bzr.dev>$ find -iname "*.py" | xargs grep -n -e ".* $" |wc -l<br>
3319<br><br>People have tried to remove it previously, but got it shot down. See eg:<br><a href="http://www.nabble.com/-MERGE--whitespace-normalization-td18634412.html">http://www.nabble.com/-MERGE--whitespace-normalization-td18634412.html</a><br>
<br>So My plan for now was to just *not* allow the situation to regress (which might in itself prove too painful).<br><br>regards<br>marius<br><br>