This is a followup patch to "Give proper error message for diff with non-existent dotted revno", it * adds a direct test on TestRevisionSpec_revno  (which does check for the correct exception) * while I was at it I also added blackbox tests of log -c  and log -r with non-existing revnos   because the dotted version of both didn't give the proper error message before the previous patch. <div class="gmail_quote">2008/12/1 John Arbash Meinel <<a href="mailto:john@arbash-meinel.com">john@arbash-meinel.com</a>> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">This seems like something that should be a direct test on RevisionSpec_revno, rather than tested at the 'diff' level. One test there is fine, but the detailed tests should be asserting that errors.InvalidRevisionSpec is being raised. I believe "len(revisions) != 1" is because at one point we had a bug in our dotted revnos when you had ghosts, which could cause more than one revision to have the same revno. This has since been fixed, so doing:  if not revisions: or  if revisions == [] or something like that would be fine as well. Anyway, that was how you could have gotten "None" as the revision_id, but still had something that was somewhat valid. So I think the fix is appropriate. Anyway, I'd like to see the tests cleaned up, but as this is still an improvement and it *is* tested I'll go ahead and merge it. </blockquote></div>