2008/12/2 John Arbash Meinel <span dir="ltr"><<a href="mailto:john@arbash-meinel.com">john@arbash-meinel.com</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
</div><div><div></div><div class="Wj3C7c">Vincent Ladeuil wrote:<br>
> I didn't follow closely how we end up changing the default<br>
> behavior of branch.nick *but* please take into account that it<br>
> 'breaks' the test suite when run in a bound branch.<br>
><br>
> One of the reasons is that some tests use 'bzr --version' as a<br>
> 'do very little' command and, when the bound branch requires some<br>
> password (like any ssh one does)... selftest prompts and hangs..<br>
><br>
> I use an ssh agent but the test suite (rightly) reset the<br>
> SSH_AUTH_SOCK.<br>
><br>
> bzr selftest -s bb.test_selftest.TestRunBzrSubprocess.test_run_bzr_subprocess<br>
><br>
> is one such test.<br><br>
</div></div>That certainly sounds like a test case that needs a bit more isolation<br>
from the outside world.<br>
<br>
I also ran into problems with this in my "show the nick of the current<br>
branch" script I run to generate my command prompt. Suddenly just doing<br>
"cd bzr.dev" would take 5s+ to show the prompt because it was connecting<br>
and probing for the nickname of <a href="http://bazaar-vcs.org/bzr/bzr.dev" target="_blank">http://bazaar-vcs.org/bzr/bzr.dev</a><br>
<br>
I hacked around it in my script, to detect if there was an explicit<br>
local nick and if not, just use "<notlocal>".<br>
<br>
I suppose when Branch.get_nick(local=False) becomes officially<br>
available, I can switch to that.<br>
<br>
In the end, I probably have to reverse my opinion that using the nick of<br>
the master is better than using the local nick. There is a lot more<br>
overhead to grab the remote value, and 'nick' seems like something that<br>
should be trivially fast to compute.<br>
<div class="Ih2E3d"></div></blockquote></div><br>let me know if/when you guys decided. Then I can work on it.<br>Originally I had switch set the nick, can we go back to that then? <br>(and also remove/depreciate the parameters from Branch._get_nick())<br>
<br>regards<br>marius<br>