2008/11/19 Alexander Belchenko <<a href="mailto:bialix@ukr.net">bialix@ukr.net</a>> <div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Marius Kruger пишет: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> hi 2008/11/19 Alexander Belchenko <<a href="mailto:bialix@ukr.net" target="_blank">bialix@ukr.net</a> <mailto:<a href="mailto:bialix@ukr.net" target="_blank">bialix@ukr.net</a>>><div class="Ih2E3d">    Marius Kruger пишет:    === modified file 'bzrlib/branch.py'    --- bzrlib/branch.py    2008-11-15 22:12:26 +0000    +++ bzrlib/branch.py    2008-11-18 21:50:10 +0000    @@ -148,9 +148,10 @@        def get_config(self):            return BranchConfig(self)    -    def _get_nick(self, possible_transports=None):    +    def _get_nick(self, local=False, possible_transports=None):    Usually new args appended to the end of arg list to reduce errors. I know, but since 1) I introduced possible_transports very recently 2) it is in a protected method </div></blockquote> Python has no protected methods.</blockquote><div>Ok fine, I dont have  a better word for non-public method <pre>(pep8: Use one leading underscore only for non-public methods and instance variables.) </pre>  </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="Ih2E3d"> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> 3) it is used exactly once 4) for some reason I thought possible_transports could be removed when making the masterbranch-authentication happen after obtaining the massage again. But thinking about it again, I don't think that would be possible. So I can change it for you if you insist. </blockquote> </div> I don't care but Jelmer has objections. </blockquote></div> to me it looks like he objects about the fact that a parameter has been added, not about where it is added. regards marius