<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div class="Wj3C7c">Javier Derderian wrote: | | Hi! | | |     You need to be aware of how it may affect the application's |     responsiveness: bzrlib is an synchronous API, meaning that when it |     takes a long time to complete a command, it prevents anything else |     from running in the same thread. | | | I'm planning to integrate bzr progress indicators in this plugin, and that | makes the "waiting" much smoother, i think. | Anyway, I'll also do some test running bzr commands inside threads | to allow gedit to keep working. But since the commands that took | loonger (pull, push, etc) have a dialog and that dialog is modal | it may not be a bad idea to just work with the progress indicator. | | -- | Javier Derderian </div></div> | <a href="mailto:javierder@gmail.com" target="_blank">javierder@gmail.com</a> <mailto:<a href="mailto:javierder@gmail.com" target="_blank">javierder@gmail.com</a>><div class="Ih2E3d"> | --- | En la Alegría serás Imbatible </div> I know there are a few places inside bzrlib that are explicitly not threadsafe. I've encountered it mostly through the ui_factory.get_nested_progress(). Specifically, it assumes that it grows as a simple stack, and the last process to be started is the first to call .finished(). A lot of the code is probably thread safe, but the UI code is not. It might be possible to write your own ui_factory which was thread safe, which would then not cause this problem. Just letting you know what I've run into. John =:-> </blockquote><div> Hi! I've been already playing working with my own ui_factory, taking code from bzr-gtk own ui_factory and integrating it with my plugin, and it seemed to work just fine. Anyway, i have to do more tests with threads. </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org" target="_blank">http://enigmail.mozdev.org</a> iEYEARECAAYFAkgOPwAACgkQJdeBCYSNAAP+mACgjismFIyzCCQSiJfioK5OVlgH PMEAn1FFESxDS33B2SA9awXBYDp2+tZL =kWCB -----END PGP SIGNATURE----- </blockquote></div> -- Javier Derderian <a href="mailto:javierder@gmail.com">javierder@gmail.com</a> --- En la Alegría serás Imbatible