<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
<br>
<br>
Robert Collins wrote:<br>
<span style="white-space: pre;">><br>
> I haven't read the whole patch just yet, only glanced over it.
However I<br>
> note you are moving imports around into if blocks and the like.<br>
></span><br>
And I only moved 1 import. I completely removed two other redundant
ones.<br>
And I moved it within the if cos there are a few other places that do<br>
the same.<br>
<br>
<span style="white-space: pre;">> Our coding standard is that
imports should be done at the top of the<br>
> module wherever possible. Lazy imports make the cost of doing
that<br>
> negligible if the import isn't actually used during a particular
method<br>
> call, and it keeps the locking involved in imports outside of
inner<br>
> loops and so on.</span><br>
That's cool. Though there are plenty of places where there are<br>
already imports within the code - should they also be relocated to the<br>
beginning of the module?<br>
<br>
Btw, the import changes are totally irrelevant to the log patch<br>
itself, so I could also just revert them.<br>
<br>
Cheers,<br>
Kent.<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.6 (GNU/Linux)<br>
Comment: Using GnuPG with Mozilla - <a class="moz-txt-link-freetext" href="http://enigmail.mozdev.org">http://enigmail.mozdev.org</a><br>
<br>
iD8DBQFHQMoegoxTFTi1P8QRAnmEAJsHJJQeAmeKMsxp0Awbxrqr9xQsNwCeLlSo<br>
26EnVwYcdHO0f89L8iLrqPo=<br>
=rNfK<br>
-----END PGP SIGNATURE-----<br>
<br>
</body>
</html>