hi,<br><br>On 9/25/07, <b class="gmail_sendername">Martin Pool</b> <<a href="mailto:mbp@canonical.com">mbp@canonical.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Martin Pool has voted comment.<br>Status is now: Semi-approved<br>Comment:<br>In the case of test_remove_changed_files_from_child_dir - I don't see<br>why we're trying to remove . - it seems a bit unnecessary. It might be
<br>better to remove '.' from the removed file list and see if that passes<br>on Windows, unless anyone can see why we really want to keep it.<br></blockquote></div><br>I think we should rather split out the '.' case, than just remove it.
<br>Since it is something a user might do, <br>we should have a test for it.<br><br>Is the current behaviour on windows acceptable for this or is it giving a nasty traceback?<br>Should the method be modified to give a nice error message/warning?
<br><br><br>regards<br>marius<br><br>