<br><br><div><span class="gmail_quote">On 4/19/07, <b class="gmail_sendername">Aaron Bentley</b> <<a href="mailto:aaron.bentley@utoronto.ca">aaron.bentley@utoronto.ca</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
It also introduces WorkingTree.canonicalpath, which is<br>untested. Its docstring is faulty (should be 'normalize'), and its<br>purpose is unclear. </blockquote><div><br>I can change the doc string to<br> """Normalize filename
<br><br> Returns the filename relative to the working tree base,<br> resolving pathelements like '.', '..', and removing trailing slashes<br> for directories.<br> """
<br></div>and add explicit tests (it is tested but implicitly)<br><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Is it supposed to resolve symlinks, for example?
</blockquote><div><br>no <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">What about hard links?</blockquote><div><br>no, <br>is this needed?
<br></div></div><br><br>regards<br>marius<br><br>-- <br><br>I don't trust a Revision Control System with less than 5900 unit tests.