On 4/20/07, <b class="gmail_sendername">Martin Pool</b> <<a href="mailto:mbp@sourcefrog.net">mbp@sourcefrog.net</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
If John was ok with this then it seems that all the review comments<br>are fixed and we're good to merge it. I'll wait til tomorrow in case<br>anyone comments and do it then.</blockquote><div><br> <br>
so just for jonk=john here is a bundle which is even less magical, just for in case (JFIC)<br>
*** I'm intentionally not letting this go directly to bundle buggy *** because I'd<br>
rather have v6 merged than v7, but I'm sending it to the list for in case john or <br>
someone-else prefers v7 (I'm away this weekend).<br>
I made a diff since bundle 5 again for easier reviewing<br><br>
</div><br></div>from google chat (I hope its ok that I pasted it here martin..too late now..):<br>==<br><span></span><span></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>jonk == john?
</span></div><div class="bz_msg_cont">a typo i presume -- so if you talked to him about it and he was ok, it's ok with me</div></div></span><span><div class="bz_msg"><div><span class="bz_history_info">Sent at 11:14 AM on Friday
</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>and i think aaron's only concern was the normpath, which you've done?</span></div></div></span><span><div class="bz_msg">
<div><span class="bz_history_info">Sent at 11:15 AM on Friday</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>ok i am going to go soon</span></div></div></span><span>
<div class="bz_msg"><div><b style="margin-left: 3px;">me: </b><span>yip, I removed it</span></div><div class="bz_msg_cont">jonk=john</div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b>
<span>so we're good to go?</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">me: </b><span>I donno, I don't know if john is 100%</span></div></div></span><span><div class="bz_msg">
<div><b style="margin-left: 3px;">Martin: </b><span>i'll see what he says overnight</span></div><div class="bz_msg_cont">he may merge it</div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">me:
</b><span>I am wiling to convert to lists for you</span></div><div class="bz_msg_cont">for in case</div></div></span><span><div class="bz_msg"><div><span class="bz_history_info">Sent at 11:21 AM on Friday</span></div></div>
</span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>the only thing that worries me is the inconsistency between different tests</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">
me: </b><span>like what?</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>that this syntax works in the remove tests, but not elsewhere</span></div><div class="bz_msg_cont">
but maybe we can move it to a superclass later</div><div class="bz_msg_cont">i don't see it as a really big deal</div></div></span><span><div class="bz_msg"><div><span class="bz_history_info">Sent at 11:27 AM on Friday
</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>i should really go...</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">me: </b><span>
in general don't you think 'bzr rm xyz' is nicer than ['bzr','remove,'xyz']?</span></div><div class="bz_msg_cont">ok sorry t</div><div class="bz_msg_cont">thanks</div></div></span><span><div class="bz_msg">
<div><b style="margin-left: 3px;">Martin: </b><span>i do</span></div><div class="bz_msg_cont">so i would be happy to have that in the base class</div><div class="bz_msg_cont">good night!</div></div></span><span><div class="bz_msg">
<div><b style="margin-left: 3px;">me: </b><span>bye</span></div></div></span><span><div class="bz_msg"><div><b style="margin-left: 3px;">Martin: </b><span>i think john's concern was just about merging it at the same time
</span></div><div class="bz_msg_cont">bye!</div></div></span><span><div class="bz_msg"><div><span class="bz_history_info">Sent at 11:29 AM on Friday</span></div></div></span>==<br><br><br><br>regards<br>marius<br><br clear="all">
<br>-- <br><br>I don't trust a Revision Control System with less than 5900 unit tests.