strike 5 attached diff and zipped bundle again, hope its more better this time. <div>On 1/18/07, Aaron Bentley <<a href="mailto:aaron.bentley@utoronto.ca"> aaron.bentley@utoronto.ca</a>> wrote: <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Would you like me to address the comments lying around the list and > submit another patch. That's not necessary to me, since I've promised to address them when merging.  I don't think you need to, but it might be a bit clearer. </blockquote></div> here is the stuff I addressed: 1)  Changed "FilesExist" to more specific "RenameFailedFilesExist"  (John's comments)      - I didn't realize that its introduced and thus only used by this patch.        I did though it might be useful to have a generic exception,        but FilesExist isn't something which would often be a problem. 2) Fixed errors.py import order 3) Improved WorkingTree._move Exception catching as best I could 4) Removed extra blank lines from doc strings in test_mv.py     as suggested by martin. I thought it is neccessary after reading pep257 5) Removed assertNone,     from using other unittesting frameworks (c++& java),     I'm sort of used to have a asser*Null, but if you guys really don't think its     nice, what can I say.     I still prefer         self.assertNone(tree.path2id(path))         self.assertNone(tree.path2id(path), path+' not in working tree.')     over         self.assertIsNot (tree.path2id(path), None)         self.assertIsNot(tree.path2id(path), None, path+' not in working tree.') -- I code therefore I am.