strike 5<br><br>attached diff and zipped bundle again, <br>hope its more better this time.<br><br><div><span class="gmail_quote">On 1/18/07, <b class="gmail_sendername">Aaron Bentley</b> <<a href="mailto:aaron.bentley@utoronto.ca">
aaron.bentley@utoronto.ca</a>> wrote:</span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Would you like me to address the comments lying around the list and
<br>> submit another patch.<br><br>That's not necessary to me, since I've promised to address them when<br>merging. I don't think you need to, but it might be a bit clearer.<br></blockquote></div><br>here is the stuff I addressed:
<br><br>1) Changed "FilesExist" to more specific "RenameFailedFilesExist" (John's comments)<br> - I didn't realize that its introduced and thus only used by this patch.<br> I did though it might be useful to have a generic exception,
<br> but FilesExist isn't something which would often be a problem.<br>2) Fixed errors.py import order<br>3) Improved WorkingTree._move Exception catching as best I could<br>4) Removed extra blank lines from doc strings in test_mv.py
<br> as suggested by martin. I thought it is neccessary after reading pep257<br clear="all">5) Removed assertNone, <br> from using other unittesting frameworks (c++& java),<br> I'm sort of used to have a asser*Null, but if you guys really don't think its
<br> nice, what can I say.<br> I still prefer <br> self.assertNone(tree.path2id(path))<br> self.assertNone(tree.path2id(path), path+' not in working tree.')<br> over<br> self.assertIsNot
(tree.path2id(path), None) <br> self.assertIsNot(tree.path2id(path), None, path+' not in working tree.') <br><br>-- <br><br><br><br>I code therefore I am.