hi,<br><br>I see I've also missed 0.14, but thats ok.<br>I just have some questions before I post a new bundle.<br><br><br><blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">
@@ -830,14 +822,14 @@<br> def merge_modified(self):<br> try:<br> hashfile = self._control_files.get('merge<div style="direction: ltr;">-hashes')<br>- - except NoSuchFile:<br>+ except
errors.NoSuchFile:<br><br>I have to say that it's kinda frustrating plowing through all these<br>unrelated changes in order to review this new mv thing.</div></blockquote><div>I'm sorry about that, I was told that the "errors." syntax should
<br>be used from now on and I'm one for fixing stuff immediately if<br>they should be fixed. But I see your point. <br>Do you want me to split it up so that we have a separate bundle<br>to fixup all errors in bzrlib/workingtree.py ?
<br> <br><br><blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">@@ -147,3 +152,151 @@<br> self.run_bzr('mv', 'c/b', 'b')
<br> tree = workingtree.WorkingTree.open('.')<br> self.assertEqual('b-id', tree.path2id('b'))<br>+<br>+ def test_mv_already_moved_file<div style="direction: ltr;">(self):<br>+ """a is in repository, b does not exist. User does
<br>+ mv a b; bzr mv a b"""<br><br>^^^ Docstrings should have a one-line summary, then an empty line, then<br>a longer description. </div></blockquote>I can't make up my mind how these doc strings should look
<br>(I'm going around in circles changing it),<br>It is quite difficult to describe these tests in one line without<br>almost exactly copying the method name.<br>Please tel me which one you would prefer (or give a better suggestion).
<br><br> def test_mv_already_moved_file(self):<br> """Test bzr mv existing_file to new_file.<br><br> a is in the working tree, b does not exist.<br> User does mv a b; bzr mv a b<br><br>
"""<br><br> def test_mv_already_moved_file(self):<br> """Test bzr mv [existing file] [new file].<br><br> a is in the working tree, b does not exist.<br> User does mv a b; bzr mv a b
<br><br> """<br><br> def test_mv_already_moved_file_into_unversioned_subdir(self):<br> """Test bzr mv [already moved file] into [unversioned subdirectory].<br><br> a is in the working tree, sub1/ is not.
<br> User does mv a sub1/a; bzr mv a sub1/a<br><br> """<br></div><br><br><br clear="all">regards<br>marius<br><br>-- <br><br><br><br>I code therefore I am.