Spurious test failures in open_write_stream

[Jelmer Vernooij]

Hi,

While trying to build bzr 2.4.0 on hardy, I am running into spurious test failures in open_write_stream when being called from _write_index.

I've seen this particular exception being raised from various different tests. For some reason I can only reproduce the problem on the buildds an not on my local machine.

Especially the fact that the failures are spurious and not locally reproducible make it hard to fix this.

Has anybody seen these errors before? This is the traceback from one of the errors:

ERROR: bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all
----------------------------------------------------------------------
_StringException: Text attachment: log
------------
210.429  creating repository in file:///tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch/.bzr/.
210.433  creating branch<bzrlib.branch.BzrBranchFormat7 object at 0xe1346ec>  in file:///tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch/
210.451  trying to create missing lock '/tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch/.bzr/checkout/dirstate'
210.472  opening working tree '/tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch'
210.499  preparing to commit
     INFO  Committing to: /tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch/
210.504  Selecting files for commit with filter None
     INFO  added a
     INFO  Committed revision 1.
210.539  Committed revid r1 as revno 1.
210.575  preparing to commit
     INFO  Committing to: /tmp/testbzr-00q0sT.tmp/bzrlib.tests.blackbox.test_version_info.TestVersionInfo.test_custom_implies_all/work/branch/
210.579  Selecting files for commit with filter None
     INFO  added b
210.604  aborting commit write group because of exception:
210.605  Traceback (most recent call last):
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/commit.py", line 440, in _commit
     self.rev_id = self.builder.commit(self.message)
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/vf_repository.py", line 200, in commit
     self.repository.commit_write_group()
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/repository.py", line 641, in commit_write_group
     result = self._commit_write_group()
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/repofmt/pack_repo.py", line 1711, in _commit_write_group
     hint = self._pack_collection._commit_write_group()
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/repofmt/pack_repo.py", line 1596, in _commit_write_group
     self._new_pack.finish()
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/repofmt/pack_repo.py", line 486, in finish
     self._write_index('text', self.text_index, 'file texts', suspend)
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/repofmt/pack_repo.py", line 546, in _write_index
     mode=self._file_mode)
   File "/build/buildd/bzr-2.4.0/build/lib.linux-i686-2.5/bzrlib/transport/local.py", line 331, in open_write_stream
     handle = osutils.open_file(abspath, 'wb')
IOError: [Errno 21] Is a directory

Cheers,

Jelmer