RFC: advisory "branch_status" flag in branch.conf

Jelmer Vernooij jelmer at samba.org
Thu May 5 15:27:14 UTC 2011


On Thu, 2011-05-05 at 07:26 +0200, vila wrote:
> >>>>> Jelmer Vernooij <jelmer at samba.org> writes:
> <snip/>
> 
>     >> As a better way of handling this, I am proposing an option in
>     >> branch.conf called "branch_status" with possible values including at
>     >> least "active" and "inactive".  bzr-colo could then use this flag to
>     >> hide branches marked with "branch_status = inactive".  The reason that
>     >> I bring this up on list is that I wonder if such an option could be
>     >> used profitably by other parts of the Bazaar ecosystem (qbzr,
>     >> bzr-explorer, etc.)  Interested parties could add other values of the
>     >> option for their own purposes.  Also, this option would occupy the
>     >> default branch.conf namespace and so the option name "branch_status"
>     >> couldn't be used by anyone else.
> 
> Thanks for rfc'ing about config option names !
> 
> Note that the current plan[1] is to introduce a more formalized name space
> to address this kind of issue by prefixing plugin specific options by
> the plugin name. In this case, you can just use 'colo.branch.status' and
> don't worry about collisions.
I like the fact that our plugins are very well integrated at the moment
- as a user you don't need to know what plugin a command is in to run
it. 

Adding some hierarchy to the configuration options makes sense, but I
wonder if the plugin that happens to be using a particular option is
really relevant. For example, what about options that are used by
multiple plugins?

I'm not necessarily disagreeing with you that it would be useful to
prefix the option with "colo.", but I think it should have that prefix
because it applies only to colocated branches, not because it happens to
be used by the bzr-colo plugin. 

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <https://lists.ubuntu.com/archives/bazaar/attachments/20110505/a4dfa0a8/attachment.pgp>


More information about the bazaar mailing list