[qbzr] GUI for shelve/unshelve

[Iwata]

Hi.

Thank you for feedback.

> What do you mean by "tests"? Automatic unit tests? We don't require it
> to merge submissions to QBzr.

I mean some unit tests and self dogfooding.
But now, merge proposal has been created. OK, let's make it together :-)

> What about splitting hunks?
I have plan to support external editor and hunk splitting, but do
nothing about it yet.
If it is a vital feature for shelve, I'll try to implement it.

> I don't understand why you need Shelve button there? This dialog
> should be used for unshelve, unshelve --preview and unshelve --delete,
> right? So Shelve button is superfluous here, IMO. Can you explain your
> thoughts on this?

I've thought this is shelvelist, not qunshelve.
So, it is natural for me that 'add shelf' and 'remove shelf' are on it.
+1, I sometimes use shelve as simple patch list.
So, When I want to switch another patch, it is convenient that
shelving current changes and unshelving another shelf can be done by
seamless action.

But I don't stick with this opinion.
If you think is should be removed, I'll remove it.

Regards.

2011/5/5 Alexander Belchenko <bialix at ukr.net>:
> Iwata пишет:
>> I'm trying to implement qshelve command.
>
> Many thanks for this! That's very cool. I think everybody will be
> happy to see it landed very soon.
>
>> Now, most of all functions has implemented, but still need tests.
>
> What do you mean by "tests"? Automatic unit tests? We don't require it
> to merge submissions to QBzr.
>
> Or are you talking about broader beta testing with real changes?
>
>>  I'm happy if you give me your opinions about these dialogs.
>
> What about splitting hunks? Currently CLI shelve requires external
> side-by-side diff editor to allow hunk splitting. At least we can
> support the same approach with external editor. I can't imagine my
> shelve usage without hunk splitting. That won't block your work, of
> course.
>
>> Screen shots
>
>>  * bzr shelve --list
>>    http://dl.dropbox.com/u/16802579/shelvelist.png
>
> I don't understand why you need Shelve button there? This dialog
> should be used for unshelve, unshelve --preview and unshelve --delete,
> right? So Shelve button is superfluous here, IMO. Can you explain your
> thoughts on this?
>
> --
> All the dude wanted was his rug back
>
> --
> You received this message because you are subscribed to the QBzr group.
> To post to this group, send email to qbzr at googlegroups.com
> To change your subscription options, visit this group at
> http://groups.google.com/group/qbzr
>