[rfc] bzr-colo into core

[Martin Pool]

On 25 March 2011 02:23, Jelmer Vernooij <jelmer at canonical.com> wrote:
> On Thu, 2011-03-24 at 16:47 +0200, Alexander Belchenko wrote:
>> Jelmer Vernooij пишет:
>> > bzr-colocated is really simple (roughly 200 lines of code vs 3000 in
>> > bzr-colo) as it relies on most of the infrastructure already being in
>> > bzrlib. It doesn't add any extra commands for dealing with colocated
>> > branches but relies on the existing ones. bzr-colo adds its own set of
>> > commands that known about colocated branches.
>> Does bzr-colocated has an equivalent of colo-branches to list all
>> available branches and highlight the active one?
> bzr-colocated just provides a format, it is supposed to integrate with
> the standard bzr commands.
>
>> The size of bzr-colo codebase is bigger because it provides many new
>> commands and help. Even qbzr integration.
> Those commands don't use the normal Bazaar API though, they bypass it.
> The commands are very specific to bzr-colo, they don't work with hg or
> git colocated branches. I realize that was not the original intent of
> bzr-colo, which was to get something actually working rather than
> waiting for the infrastructure in bzrlib to mature. I'm also not saying
> these commands are not useful, but that doesn't mean we should merge
> them as is.

I think we could quite reasonably hook bzr-colo on to the named branch
infrastructure, couldn't we? Just make the current bzrdir format
(BzrDirMetaFormat1) implement open_branch(name=foo) by looking for a
branches/foo and opening that.

-- 
Martin