Windows file locking with bzr 2.2.3

[W. Trevor King]

On Thu, Feb 24, 2011 at 09:29:17PM +0000, Martin (gzlist) wrote:
> On 24/02/2011, W. Trevor King <wking at drexel.edu> wrote:
> >
> > I see two possibilities:
> 
> Both of which may be right.
> 
> > 1) I'm calling cmd_add wrong.  Certainly a possibility, since the
> > calling conventions have changed a few times over the past two years.
> 
> If you're only ever passing the cwd for 'file_ids_from' Don't Do That.
> This change makes your test script work for me:
> ...

Excellent, thanks.

> If it's sometimes meaningful and this was just the test script
> simplifying things then see the following.

It is sometimes meaningful.

> One option for a fix in bzrlib would be just to detect that situation
> and only lock the tree once, or raise a user error.

I'll leave this up to you folks ;).

> In your code, omitting the parameter only if it's the current tree
> will work with current bzrlib releases and in future when the bug is
> fixed.

I'll go this way, and post my logic to this thread in case you want to
copy it in your fix.

On Thu, Feb 24, 2011 at 03:47:52PM -0600, John Arbash Meinel wrote:
> On Windows, taking an exclusive lock blocks all other requests, even
> from the same process. IMO Windows makes more sense here, for whatever
> the purpose of locking the file, most logic will assume they got what
> they asked for. (Thread1 thinks it has an exclusive lock, so does
> thread2, but they can both mutate the state on Linux.)

I don't really understand how stricter locking ties into explicitly
listing a root directory, but I suppose that doesn't really matter to
me ;).

I hope nobody ever emails the BE list requesting file locking, since
it looks really annoying ;).

Thanks for the quick diagnosis!

-- 
This email may be signed or encrypted with GPG (http://www.gnupg.org).
The GPG signature (if present) will be attached as 'signature.asc'.
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/bazaar/attachments/20110224/c8013ca8/attachment-0001.pgp>