Default hook state and the test suite

[Gordon Tyler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/20/2010 9:16 PM, Martin Pool wrote:
> On 20 October 2010 09:41, Gordon Tyler <gordon at doxxx.net> wrote:
>> Perhaps I'm lacking some context here. Whether plugins are enabled or
>> not seems to me to be a function of who/what is running the tests. A
>> plugin author would run selftest with plugins enabled because they want
>> to test their plugin. Babune would run selftest with plugins disabled
>> because there you're more concerned with core functionality, right? And
>> Babune could even run selftest a second time with plugins enabled as
>> part of an integration build, using the set of plugins that are included
>> with the installers.
> 
> Right.  So is the question just what the default should be?
> 
> I think defaulting to no plugins for selftest would sweep the problem
> under the carpet.

Good point.

> I'd like to either work towards getting a totally clean suite with
> typical plugins; and/or to coming up with a better idea for how to
> test the interaction of core and plugins.

You're already part of the way there with Babune. What's needed is to
define a typical set of plugins and have a separate selftest run with
those enabled, in addition to selftest with no plugins. Differences in
test results indicate bugs due to plugins.

Ciao,
Gordon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJMv7Z7AAoJEIrPJfWinA2uaNsH/jh1RymgC/R9cqCVnWF6G1gC
Q7UVrnycFJXX5kLUR0wrsyBnuJhrGu8+mBmpYnob9nzNYyYV0z/tFX/CL12+7h+8
N3lVQP+0S2YEdsgT1Ri6pPSGm2LO/03aCez36GWG3saXE6l7yXkkYoek2zP1CCgG
7NAEdbejqckQqFM7K7MCwOHOygl6331RC18Nzn5zTR+sO9Y1RABJCa4dbOJ++L1A
4u2sbVsHDYsPeCckKQPsbcgRzHEPcoQOrtjB+2bGKEuQKnCKyj50JV88f7dgVqHt
pTm/Vj9uYoBhL33Rvm5JIVrBlQNenNSb0joDrW4VZW9D9DFlEtutZfM1XHLBuA0=
=mG/1
-----END PGP SIGNATURE-----