Default hook state and the test suite

[Vincent Ladeuil]

>>>>> Gordon Tyler <gordon at doxxx.net> writes:

    > On 10/19/2010 9:43 AM, John Arbash Meinel wrote:
    >> On 10/18/2010 6:30 PM, Gordon Tyler wrote:
    >>> On 10/18/2010 5:35 PM, John Arbash Meinel wrote:
    >>>> I'm worried about a whole in our testing setup. Specifically, we have at
    >>>> least one case where by default we have a hook installed at runtime (by
    >>>> bzrlib), and the test suite defaults to clearing all hooks. It means
    >>>> that we aren't testing the "stock" behavior. Which was the point of
    >>>> clearing the hooks (so that plugins wouldn't cause test failures when
    >>>> they hook in for extra information.)
    >> 
    >>> Perhaps selftest should disable plugins unless --enable-plugins is supplied?
    >> 
    >> Then you can't run the plugin tests... Which ideally we would get back
    >> to having all plugin tests run clean as well.

    > Perhaps I'm lacking some context here. Whether plugins are enabled or
    > not seems to me to be a function of who/what is running the tests. A
    > plugin author would run selftest with plugins enabled because they want
    > to test their plugin. Babune would run selftest with plugins disabled
    > because there you're more concerned with core functionality, right? And
    > Babune could even run selftest a second time with plugins enabled as
    > part of an integration build, using the set of plugins that are included
    > with the installers.

I think you got it right.

Except that there are better ways to select which plugins are enabled
for a given run using BZR_PLUGIN_PATH and friends.

    Vincent