Default hook state and the test suite

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2010 6:30 PM, Gordon Tyler wrote:
> On 10/18/2010 5:35 PM, John Arbash Meinel wrote:
>> I'm worried about a whole in our testing setup. Specifically, we have at
>> least one case where by default we have a hook installed at runtime (by
>> bzrlib), and the test suite defaults to clearing all hooks. It means
>> that we aren't testing the "stock" behavior. Which was the point of
>> clearing the hooks (so that plugins wouldn't cause test failures when
>> they hook in for extra information.)
> 
> Perhaps selftest should disable plugins unless --enable-plugins is supplied?
> 
> Ciao,
> Gordon
> 

Then you can't run the plugin tests... Which ideally we would get back
to having all plugin tests run clean as well.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAky9oIIACgkQJdeBCYSNAAMQYwCfepx+lNrPJHxD6Id7Szcd6hZq
DigAnRH8LtwBwMr7uID8CJJJkjC6P44h
=PIAx
-----END PGP SIGNATURE-----