Tortoisebzr leaves locks behind

[Patrick van der Velde]

Hi John

Thanks for that. I'll file a bug for Tortoise. Also for the record,
all these problems are on the local machine, no network transport
involved at all.

Thanks

Patrick

On Wed, Oct 13, 2010 at 03:22, John Arbash Meinel
<john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/12/2010 6:01 AM, Patrick van der Velde wrote:
>> Hi All
>>
>> Has anybody noticed that TortoiseBzr seems to leave locks behind when
>> it fails to handle the users request correctly? I've noticed that I
>> have to use break-lock on a regular basis after using TortoiseBzr. Is
>> there something I can do to make this not happen (config, etc.)? Or is
>> this a bug / by design / feature / ....???
>>
>> Thanks
>>
>> Patrick
>
> My guess is that it is a bug that TBZR isn't cleaning up after itself
> properly. Code in bzrlib tends to look like:
>
>  branch.lock_*()
>  try:
>    do something
>  finally:
>   branch.unlock()
>
> So that it will always unlock the branch whether "do something" succeeds
> or fails.
>
> People could also write this as:
>
> branch.lock_*()
> do something
> branch.unlock()
>
> In which case it only unlocks if do something succeeds without an exception.
>
>
> The other possibility is if you are accessing stuff via sftp/bzr+ssh and
> we can't unlock because the network communication is being closed.
>
> John
> =:->
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAky0bzIACgkQJdeBCYSNAAPGoACfTy+rPuNwA/TsnK//gFcMAosL
> JToAni5+s3l2HfQ7/C4ygwLZMLSQ/weR
> =uwbw
> -----END PGP SIGNATURE-----
>