Patch Pilot report for 20-24 Sept
Andrew Bennetts
andrew.bennetts at canonical.com
Fri Sep 24 09:12:56 BST 2010
In short: the review queue is alarmingly long... but it is also moving at a
reasonable pace.
Reviews are starting to pile up. 17 branches landed so far this week
(and #18 is currently on its way), so it's not lack of landings so much
as the proliferation of branches! Lots of documentation fixes, special
thanks to John Barstow for the mini-flood of those :)
In summary:
* I currently see 7 Approved branches (plus the 1 currently playing on
PQM).
* I see 2 branches with Approve votes but not Approved status (plus 2
that are included in the branch currently playing on PQM).
* Several branches with very lengthy discussions (10+ comments)
Of the Approved-but-unlanded, 2 are probably only blocked by NEWS
conflicts. I tried to get news_merge activated on PQM, but it
apparently hasn't worked. There's at least 1 currently that is "ready
to merge, but let's wait a day or two in case the submitter adds a NEWS
entry, because that would be nice, and it's a pain for someone else to
do it[1]", and it hasn't been the only one like that this week. There's a
branch of mine which I'm going to put back in Work in Progress as I type
this because there's an unresolved question that came up after PQM
rejected it. And at least one that was rejected by PQM due to a 'make
check' failure.
So the "Approved" list is actually a messy mix of "Approved, ready to
land" and "Approved in principle... but not quite ready."
Almost every single branch on
https://code.edge.launchpad.net/bzr/+activereviews has had at least some
feedback, which is great, thank you reviewers!
Final thought:
<https://code.edge.launchpad.net/bzr/+merges?field.status=WORK_IN_PROGRESS>
is quite long. If you've read this far, why not take a look and see if
you can do something about that? :)
-Andrew.
[1] I'm pretty sure I've filed a bug on launchpad-code about this in the
past, but I don't have the bug number handy.
More information about the bazaar
mailing list