Rev 5398: (vila, jam) Get PQM running correctly again (bug #626667), in file:///home/pqm/archives/thelove/bzr/%2Btrunk/

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/31/2010 2:21 AM, Vincent Ladeuil wrote:
>>>>>> John Arbash Meinel <john at arbash-meinel.com> writes:
> 
>     > On 8/30/2010 9:49 PM, Matthew D. Fuller wrote:
>     >>> --- a/Makefile	2010-04-06 06:59:03 +0000
>     >>> +++ b/Makefile	2010-08-30 21:23:49 +0000
>     >>> @@ -39,8 +39,14 @@
>     >>> check: docs check-nodocs
>     >>> 
>     >>> check-nodocs: extensions
>     >>> +	set -e
>     >> 
>     >> What's the point of this?  Every line of a target executes in a
>     >> different shell anyway, so this shouldn't have any effect on anything
>     >> anyway (since the shell you just `set -e` in exits at the end of the
>     >> line).
>     >> 
>     >> 
> 
> Exactly my thought, each line in the action is executed in a newly
> spawned shell...
> 
> So I digged the history a bit and obviously it had an effect for
> John... could that be that the option is somehow exported ??? Weird.
> 

I'm a bit surprised it worked as well. I would be fine changing it to
"set -e ; $(PYTHON) .." if we think that will work better.

I can definitely say that running "make check" with that line gave me a
traceback and failure, and running without it did not.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx9Ib8ACgkQJdeBCYSNAAP8lACeI+d4m5k4uPF+FbTPzHgLLqCB
Ej4AoJ2C1pEu/gCagbQMHGYKY595PZa/
=Hags
-----END PGP SIGNATURE-----