[Merge] lp:~vila/bzr/leaking-tests into lp:bzr

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Sorry to not reply to the original mp thread, but it seems the Merge
> Proposals page doesn't like attachments.
> 
> ...
> 
> Vincent Ladeuil wrote:
>>>>>>> Gordon Tyler <gordon at doxxx.net> writes:
>>     > So my test run hung at:
>>     > [9054/24198 in 17m14s, 42 failed] test_branchbuilder.TestBranchBuilder.test_get_branch
> 
>> Weird. How long did you wait ? Some tests appear to hang up to ~10 mins
>> currently.
> 
>>         Vincent
> 
> Attached is what I get when running
> $ ./bzr selftest -x blackbox.test_breakin --no-plugins --verbose [1]
> ...
> 
> Note that it clearly seems to hang from the time it prints out the test
> it is running until it gets the timeout exception. I didn't time it, but
> it certainly could be 2-minutes.
> 

So I've think I've managed to track down the issue to a _probe_bzrdir
call that doesn't seem to be cleaning up its connection. See the
attached error messages.

Basically, I wrapped socket.socket() to produce an object that tracks
the traceback when it was created, and then caches that when .connect()
is called. And then when I later get a failure at shutdown, I check who
the peer was, and print its traceback. I'm pretty sure that is correct,
though I don't entirely know why my other code doesn't find it correctly.

My guess is the socket is trapped because of something like we "raise
NotBranchError" and that leaves the socket in some sort of gc cycle.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwZY5MACgkQJdeBCYSNAAM3HgCfSaDJYuJadwENehiP1jVNetDP
2N8AnjPVazrRh4+XYkkL4Dw4yJtxrJ+6
=J3ms
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: errors.txt
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20100616/b6d52a6f/attachment-0001.txt