pqm error formatting
Martin Pool
mbp at canonical.com
Tue Jun 15 08:04:40 BST 2010
On 15 June 2010 16:29, Vincent Ladeuil <v.ladeuil+lp at free.fr> wrote:
> === modified file 'python/subunit/chunked.py'
> --- python/subunit/chunked.py 2009-10-13 04:52:06 +0000
> +++ python/subunit/chunked.py 2010-06-14 14:02:30 +0000
> @@ -87,7 +87,7 @@
> if count_chars[-1][-1] != '\n':
> return
> count_str = ''.join(count_chars)
> - self.body_length = int(count_str[:-2], 16)
> + self.body_length = int(count_str[:-1], 16)
> excess_bytes = len(count_str)
> while excess_bytes:
> if excess_bytes >= len(self.buffered_bytes[0]):
>
> Without more investigation, I strongly suspect a '\r\n' vs '\n'
> issue. Since the fix is simple I wonder if subunit can't just be more
> tolerant and accept both end-of-lines at *this* particular place (I've
> no idea if this code is used for processing other parts than the highest
> level structure so I have no strong feeling there).
This is <https://bugs.edge.launchpad.net/subunit/+bug/505078>. I
would mark that bug High not Wishlist, but I guess it's not up to me.
Maybe I will just put up a patch.
--
Martin
More information about the bazaar
mailing list