[RFC] diff header encoding for Windows users

[Martin Pool]

On 25 May 2010 19:56, Alexander Belchenko <bialix at ukr.net> wrote:
>> For now I was just going to add output_encoding and terminal_encoding
>> and then people can add more if it's necessary.
>
> What's difference between output_encoding and terminal_encoding?

It's meant to cope with the fact that on Windows the terminal encoding
is often different from the encoding you like to use for files (if I
understand correctly).  We have two functions so it seems to make
sense to have two options.

>
>> The way I intend to implement this is by adding a configuration option
>> for the encodings, then adding a per-process configuration layer that
>> can be fed by a -O option.  Then we don't need to add per-command
>> options or global options for every single thing.
>
> something like:
>
> bzr -O output_encoding=utf-8 diff
> ?
>
> My idea was just
>
> bzr --encoding=utf-8 diff
>
> similar to svn.
>
>> Your reasoning about different commands sounds ok to me.
>>
>> One might also want to explicitly configure the filename encoding on Unix.
>
> OK, good.

I don't mind if it's presented as --output-encoding but turning it
into a config variable seems better than introducing a new random
global variable, and it lets it be set per machine or per location if
that turns out to be useful.


-- 
Martin <http://launchpad.net/~mbp/>