version-info --include-history UnicodeDecodeError (518609)

[Parth Malwankar]

On Sat, Apr 3, 2010 at 4:59 AM, John Arbash Meinel
<john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin (gzlist) wrote:
>> On 02/04/2010, Parth Malwankar <parth.malwankar at gmail.com> wrote:
>>> I noticed that message is unicode and based on irc chat with lifeless
>>> I understand that message should not be unicode. Sure enough, the
>>> patch below fixes the issue.
>>
>> I'd say you have it backwards. The console streamwriter expects to be
>> given unicode that it can then coerce to the right terminal encoding,
>> but Stanza.to_lines has gone and screwed up the plan by making
>> everything UTF-8 already. Changing RioWriter.write_stanza or
>> Stanza.write looks like the correct fix to me.
>>
> Note that we have Stanza.to_unicode()...
>

Thanks for the help John, Martin. Stanza.to_unicode() fixed this.
I have proposed a merge for the fix[1].

Regards,
Parth

[1] https://code.launchpad.net/~parthm/bzr/518609-version-info-unicodedecodeerror/+merge/22801