BzrDir.has_{branch,workingtree}

John Arbash Meinel john at arbash-meinel.com
Mon Mar 22 14:59:01 GMT 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> BzrDir has two methods that just check whether a branch or working tree
> are present. Their docstrings already mention that using them is
> probably a bad idea - if you need a Branch you should just try to open
> it and deal with any exceptions that occur, rather than checking first
> if the branch is present.
> 
> There are only two users of has_branch() in the Bazaar codebase, but
> they could easily be removed. Does anybody object to it being removed?
> 
> Cheers,
> 
> Jelmer

seems fine to me. We've generally moved away from 'has' checking.
However, what is the code that is using it?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkunhbUACgkQJdeBCYSNAANFCgCfRL3Xa2enE7y+PmsMKpCT1JQ1
HYcAoJBlP44QVopfwU31hT3dV8daXTk9
=OR0E
-----END PGP SIGNATURE-----



More information about the bazaar mailing list