Win 2.1.0-1 installer bzr-explorer toolbar problem

[Ian Clatworthy]

John Arbash Meinel wrote:
> Dave Murray wrote:
>> John Arbash Meinel wrote:
>>> Note that there seems to be a problem with bzr-explorer and the
>>> all-in-one-installer. I need to investigate further, but it seems that
>>> we aren't finding the icons for the toolbar.
>> I've compared what is installed by the 2.1.0-1 installer and Explorer's
>> own installer and there are some files missing:
> 
>> clothes\
>> hats\
>> skin\
>> app-suite-bzr-gtk.ini
>> app-suite-qbzr.ini
>> menus-for-ides.xml
> 
>> The missing skin folder is causing the toolbar problem. The other missing
>> files are causing other issues.
> 
>> Dave.
> 
> 
> 
> Digging into it, it looks like it is a bad interaction with the py2exe
> sections of bzr's setup.py.

> So anything that isn't ".py", ".pyd", ".dll", or ".mo" gets excluded
> from the packaging.

> So it copies it into the first staging area, but those files don't end
> up copied into the py2exe build directory, and thus doesn't end up in
> the installer.

Sigh. That really is *terribly* broken. That implies that custom editors
and numerous other features have been silently missing for months now.

> Short-term... I don't really know. I would *like* to
> have py2exe specific stuff in bzr-windows-installers rather than bzr's
> setup.py, if only because then I can update the packaging rules without
> having to hack bzr and release a new bzr tarball.

+1 on that direction.

> Honestly, I'm not 100% sure how to fix this.

I'll take a look and see what I can do to help.

Ian C.