help needed in fixing test failure (#138600)

Alexander Belchenko bialix at ukr.net
Wed Feb 17 08:05:31 GMT 2010


Parth Malwankar пишет:
>>> === modified file 'bzrlib/tests/blackbox/test_versioning.py'
>>> --- bzrlib/tests/blackbox/test_versioning.py  2009-08-28 05:00:33 +0000
>>> +++ bzrlib/tests/blackbox/test_versioning.py  2010-02-16 09:24:13 +0000
>>> @@ -23,7 +23,7 @@
>>>  import os
>>>
>>>  from bzrlib.branch import Branch
>>> -from bzrlib.osutils import pathjoin
>>> +from bzrlib.osutils import pathjoin, isdir
>>>  from bzrlib.tests import TestCaseInTempDir, TestCaseWithTransport
>>>  from bzrlib.trace import mutter
>>>  from bzrlib.workingtree import WorkingTree
>>> @@ -121,6 +121,14 @@
>>>          from bzrlib.check import check
>>>          check(b, False)
>>>
>>> +    def test_mkdir_invalid(self):
>>> +        """Basic 'bzr mkdir' operation should fail if !branch. Fix #138600"""

May I ask to don't write "if !branch" but "if there is not branch 
[present]"? Although I'm C-programmer the sentence above makes me think 
some second to understand it.




More information about the bazaar mailing list