copyright check pre-commit hook

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philippe Lhoste wrote:
> On 10/02/2010 12:39, Marius Kruger wrote:
>> Trailing white space should be avoided, but is allowed.
>> You should however not make lots of unrelated white space changes.
>> (from doc/developers/HACKING.txt)
> 
> OK, I get it. It isn't because it breaks Python, but because it adds lot
> of noise to diffs, right?
> That's why I usually set "Ignore white space" in WinMerge... :-)
> 

Right. It is harder to review code that has a lot of lines 'changed'
just because of trailing whitespace. In theory that was why we wanted to
push to clean up the codebase and then force trailing whitespace to be
removed (in pqm). Robert found it frustrating to have things rejected by
pqm just because his editor left trailing whitespace that he didn't see,
so that got pushed back.

And, of course, some reviewers are more lenient to 'spurious' changes
than others.

code cleanup is a good thing, but it can obscure the actual content of
the patch.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkty3+QACgkQJdeBCYSNAANw/ACghGYL6mI8pwuNdmHsUFMDs4eo
a40AnRIbLx81IMJB8yyE4R5Kg4xjdbhK
=broV
-----END PGP SIGNATURE-----