[Merge] lp:~salgado/bzr/bug-308122 into lp:bzr

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Taking this to the list...

John A Meinel wrote:
> I believe this is because Unshelver is meant to be a UI class, and not a
> lower level implementation class. As in, you probably can't really
> re-use Unshelver in gui code, as it is an implementation of a text ui
> itself.

While shelf_ui.Unshelver is meant to be a UI class, that purpose doesn't
exclude being used by other code.  Someone (I think it was Jonathan
Lange) complained to me that the gap between our implementation code and
our DWIM, UI code was too large.  I think that might be an explanation
of why some people try to reuse our command classes rather than using
the APIs they are supposed to use.  So with the shelf_ui classes, I was
attempting to fill in some of the gap between command classes and the
low-level APIs.

> Which feels like we are missing the non-ui code (how *should* qunshelve
> interact with the shelf if not via Unshelver.)

I don't know what to make of this.  The obvious answer is
bzrlib.shelf.Unshelver, because that's what's used to implement this UI.
   But since you must know this, it reads as a suggestion that
bzrlib.shelf.Unshelver is inappropriate.

If you do feel that way, I would appreciate it if you would explain why
you think it is inappropriate.  If not, could you explain what you do mean?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksy5m8ACgkQ0F+nu1YWqI1ETgCfWv2OCB22qcwJArfHjVpmTDV/
mcYAn22F8i924RGFLQKXqEQNWXRC377R
=hGWs
-----END PGP SIGNATURE-----