Next steps if someone comments on your merge or sets it to needs fixing?

Gordon Tyler gordon at doxxx.net
Sun Dec 6 15:30:11 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Declan McGrath wrote:
> a) If, before continuing work, you want to clarify something reviewer
> may have said, should you simply comment against the existing merge
> proposal with your questions?

Yes.

> b) Once you have made all necessary changes to your branch should you
> then submit another merge proposal? I have resubmitted before but that
> seems to lose the original merge thread meaning that I have to add a
> link to the original merge proposal when I submit a new one.

No, just push new revisions up to the lp branch that you originally
submitted. Launchpad will automatically update the merge proposal after
a few minutes. You should add a comment once it's done that to notify
the reviewers of the changes you've made.

> c) Let's say I have submitted 3 merge proposals over a period of time.
> Is there anyway i can find a link to each one from my launchpad
> account? The only way I seem to be able to find old merge proposals is
> in my email inbox, not through launchpad.

You can find your currently active reviews or unmerged proposals from
your ~user branches page, e.g. https://code.launchpad.net/~doxxx is mine.

Ciao,
Gordon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLG84DAAoJEIrPJfWinA2uaOgH/0rJ8jeixQUZdKfZZ0g2LCW7
TvhIAxtBjF1aOnfNrC/HL09xMAxZH6IR5RMCJ2klUgc8LWSlQVKKMIcRk+reABIP
+SyJ3wXQgfkyudIuQX49AuSVJSbaeC3Q1xfpv82iWKfhK+25qtSsfDDUqVQFgF4u
0lxEwK/r3VXawmCkvws2lQkwWBmk2igKQOwiDx3PMvhx8EEkBvk3zqpl4MUQxeSp
g+Cs9CYORgh6oMZjPwcnuit+3qGF6wHjeu84FaEPizZz+8GIgj2Z7z1I2o9Zofd4
B86rHziFI+Y25+ycW7CnUZHu4BciBxNq383GUHLkBu8nX00ec5YEKNjEeyftv4w=
=JCzX
-----END PGP SIGNATURE-----



More information about the bazaar mailing list