Launchpad reviews (was Re: Patch Pilot report)

[Gordon Tyler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[Sorry Martin for the dupe, forgot to reply-all the first time.]

Martin Pool wrote:
> 2009/11/24 Robert Collins <robert.collins at canonical.com>:
>> On Tue, 2009-11-24 at 12:30 +1100, Martin Pool wrote:
>>> 2009/11/24 Gordon Tyler <gordon at doxxx.net>:
>>>> Something else that has not been clear to me from the point of view of a
>>>> contributor is when I should be resubmitting a merge proposal for which
>>>> changes have had to be made since the initial proposal. Is there some
>>>> threshold on the size of the subsequent changes above which the proposal
>>>> should be resubmitted?
>>> I think that if you're not going to land it yourself, you should
>>> always resubmit it when you update.
>> As a reviewer, I hate this. It breaks the discussion, I have to refer to
>> multiple places to see whats going on.
> 
> I think that's a flaw in the way superseded reviews work in general.
> But I don't see any better way for the person to say they've done the
> changes.  I suppose they can just comment and manually attach a diff.

It seems to me that if I push my changes up to the branch which I've
proposed for merging, those changes automatically appear in the diff for
the proposal after a few minutes. I would then post a comment saying
that I've pushed the requested changes.

Ciao,
Gordon


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLCzuzAAoJEIrPJfWinA2uUMwH/3B79Y5c7lM9NPho/rTNoWXb
1aysv4/20WQL03lkFvzb7b0KaOurRKR4msTV0wUo6XSK60Is6pvFLkRYuQC6uNwt
s5BZ3PwDFZJABVD3PtELz9UyUzIAySkO2UenwuL9NfGJqt3H8csp5NzhNNTk0nIE
CltosmurlgdoqJNmeuvK33ZvidZN2E9G9FbCJxjXgbxkBwFZm36R23xcY4c2bv+i
c69lOOvLiXKLw2MRt7VXnoys04uKcC/aJ9eLJsAJJVSllARerqViiLVP8laQwxxR
CsGwQGE6eJJBOHUpmxcun1+SVB8llUF5GpKFeOQib5zg0tM1YdU2McDGBHgUirU=
=BEd1
-----END PGP SIGNATURE-----