Launchpad reviews (was Re: Patch Pilot report)

Robert Collins robert.collins at canonical.com
Tue Nov 24 01:33:15 GMT 2009


On Tue, 2009-11-24 at 12:30 +1100, Martin Pool wrote:
> 2009/11/24 Gordon Tyler <gordon at doxxx.net>:
> > Something else that has not been clear to me from the point of view of a
> > contributor is when I should be resubmitting a merge proposal for which
> > changes have had to be made since the initial proposal. Is there some
> > threshold on the size of the subsequent changes above which the proposal
> > should be resubmitted?
> 
> I think that if you're not going to land it yourself, you should
> always resubmit it when you update.

As a reviewer, I hate this. It breaks the discussion, I have to refer to
multiple places to see whats going on.

I'd pretty much love to see the 'resubmit' button deleted (until the
fixes planned for it are completed).

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20091124/73458076/attachment.pgp 


More information about the bazaar mailing list