python version-specific codepaths in tests

John Arbash Meinel john at arbash-meinel.com
Fri Nov 20 00:49:12 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> That sounds fine.
> 
> - Martin
> 
>> On 20/11/2009 11:05 AM, "Gordon Tyler" <gordon at doxxx.net
>> <mailto:gordon at doxxx.net>> wrote:
>>
>> Would it be acceptable to make start_bzr_subprocess and
>> finish_bzr_subprocess in the test code not raise TestSkipped if Python
>> 2.6's Popen.send_signal method is available? This would allow SIGTERM to
>> be sent to subprocesses on win32, skipping fewer tests, if the selftest
>> is running on Python 2.6.
>>

I would make sure it works first. If SIGTERM is built on
TerminateProcess, I think it works, but I'd want to make sure it doesn't
kill the testing process.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksF54gACgkQJdeBCYSNAANeEgCfX9UAbiCGCYUGX6XWU+I2L8xT
EfcAn2QLSWokEQ/nk1lEpSozuLPwooVC
=AUL8
-----END PGP SIGNATURE-----



More information about the bazaar mailing list