[Fwd: Re: [Merge] lp:~jameinel/bzr/2.1.0b3-win32-shell-completion into lp:bzr]

Alexander Belchenko bialix at ukr.net
Fri Nov 6 01:19:13 GMT 2009


-------- Исходное сообщение --------
Тема: Re: [Merge] lp:~jameinel/bzr/2.1.0b3-win32-shell-completion into	lp:bzr
Дата: Thu, 05 Nov 2009 20:49:14 -0000
От: Alexander Belchenko <bialix at ukr.net>
Отвечать: mp+14445 at code.launchpad.net
Кому: John A Meinel <john at arbash-meinel.com>

Review: Needs Fixing
I've late here but I want to say my word.

John, I agree with Martin that using single quotes is bad idea. I hope you decided to remove them.
All Windows people used to double quotes so single quotes is not Windows way.

Also I think will be nice to have a way to disable this glob expansion via environment variable,
e.g. BZR_GLOB=0 or BZR_GLOB=no. Using configs there is wrong idea, but os.environ should be OK and fast.
-- 
https://code.launchpad.net/~jameinel/bzr/2.1.0b3-win32-shell-completion/+merge/14445
You are reviewing the proposed merge of lp:~jameinel/bzr/2.1.0b3-win32-shell-completion into lp:bzr.






More information about the bazaar mailing list