Launchpad plugin broken

[Martin (gzlist)]

On 05/11/2009, John Arbash Meinel <john at arbash-meinel.com> wrote:
>
> The problems accessing Launchpad are because codehosting is having
> problems right now after an upgrade. See
> http://twitter.com/launchpadstatus

Thanks, thought something must be wrong beyond my bazaar installation.

> As for the __init__ stuff... shame. I suppose we can put something like:
>
> if sys.version > (2,4):
>   # Python2.4 did not define __init__
>
> Can you test something like that, and make sure it works?

This gets me as far as launchpad's other troubles:

=== modified file 'bzrlib/plugins/launchpad/lp_registration.py'
--- old/bzrlib/plugins/launchpad/lp_registration.py     2009-10-30
21:02:37 +0000
+++ new/bzrlib/plugins/launchpad/lp_registration.py     2009-11-05
17:09:55 +0000
@@ -19,2 +19,3 @@
 import socket
+import sys
 from urlparse import urlsplit, urlunsplit
@@ -59,3 +60,4 @@
     def __init__(self, scheme, use_datetime=0):
-        xmlrpclib.Transport.__init__(self, use_datetime=use_datetime)
+        if sys.version_info > (2, 5):
+            xmlrpclib.Transport.__init__(self, use_datetime=use_datetime)
         self._scheme = scheme

I won't make a branch for the change, as I think it should be based on
something other than bzr.dev going by the log?

> We also need
> to get PQM running 2.4 again (it was upgraded recently, and the
> 'default' python changed.)

Aha, I wondered why it hadn't be caught before landing.

Martin