What is per_inventory supposed to test

Robert Collins robertc at robertcollins.net
Fri Sep 25 04:23:37 BST 2009

On Thu, 2009-09-24 at 22:07 -0500, John Arbash Meinel wrote:

> So we only have 1 "memory inventory" implementation, and as such I don't
> see it being particularly useful to have a 'per_inventory' that has 1
> implementation.

Me neither ;)

> So it seemed more reasonable to change 'per_inventory' to mean 'run the
> tests that different inventories should support for query methods'.

I think its fine either way.

> The permutations in 'test_inv.py' should really be split out into some
> sort of "per_delta" sort of suite. I think they are very valuable, but
> they aren't *really* testing things that claim to be Inventories.
> Specifically, it is testing 'add_inventory_by_delta' across all
> Repository formats, and 'update_basis_by_delta' and
> 'apply_inventory_delta' across all Working Tree formats.
> You don't have stuff like 'filter()' on working trees, for example.

In interface terms I guess its 

or something similar.

I agree that its awkward, but I don't think it creates issues where it
is, at least not at the moment.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090925/7584f52e/attachment-0002.pgp 

More information about the bazaar mailing list