[Bug 425510] Re: 'bzr mv' should do wildcard expansion on windows

Alexander Belchenko bialix at ukr.net
Wed Sep 9 15:58:22 BST 2009


John Arbash Meinel пишет:
> Vincent Ladeuil wrote:
>>>>>>> "martin" == Martin Pool <mbp at canonical.com> writes:
>> <snip/>
> 
>>     martin> Perhaps a better way to tackle this is for the
>>     martin> declaration of the argument pattern taken by the
>>     martin> command to declare which arguments will be subject to
>>     martin> expansion?
> 
>> +1
> 
>>         Vincent
> 
> 
> 
> So there is actually a way to get access to the original command line
> string that was passed. If you look at:
>  bzrlib.win32utils.get_unicode_argv
> 
> it does:
>   pargv = CommandLineToArgv(GetCommandLine(), ctypes.byref(c))
> 
> GetCommandLine() gives you the raw Unicode string as supplied by the
> caller. Which means that it has all the quoting characters, etc.
> 
> So we could simply replace "CommandLineToArgv()" with a function that
> was more 'Unixy'.

If by 'Unixy' you mean 'using shlex' then you will make things only worse.




More information about the bazaar mailing list