[RFD] Merge proposals and code reviews too private
Denys Duchier
denys.duchier at univ-orleans.fr
Wed Aug 19 22:22:21 BST 2009
Recent messages about "merge proposals and code reviews" have made it
clear that many individuals on this list are unaware of the submissions
being made on launchpad. I was too, until I recently wanted to submit a
proposal of my own.
I must admit to being just as puzzled as everyone else as to what the
correct "information propagation" policy should be. I made a merge
proposal on LP because that was documented as the preferred submission
vector; yet, it seems to me that discussions ought to take place on this
list, in the open, and not merely among us "lucky few".
"Merge proposals" on LP are also (currently) not well-suited for
extended discussions over a code contribution which is evolving as a
result of those very discussions:
- there is a specific page for a "merge proposal"; it displays the
diff at the time of submission, and there is a growing comment
thread attached.
- however if you improve the code in the branch, the diff does not
get updated. you have to "resubmit" and you get a new "merge
proposal" page; but as a consequence there is no continuity in the
discussions since they must be continued on different pages.
Perhaps we should request improvements to LP. However, in the mean
time, it would be helpful to adopt (and document) a submission protocol
that keeps every one in the loop with minimal overhead. For example:
1. submit to LP
2. post to mailing list (with URL to LP); ideally this should be
automated
3. do not resubmit (so that the discussion stays on one page)?
Cheers,
--Denys
More information about the bazaar
mailing list