[PATCH] [Bug 176292] Allow use of BZR_SSH as path to ssh client

[Martin (gzlist)]

Attached is a bundle adding the ability to specify a path to a particular ssh
client to use with bzr, as described in:
  <https://bugs.launchpad.net/bzr/+bug/176292>
There are minimal (but still slightly incompatible) changes to the current
behaviour. Notably, the environmental variable can still be one of a set of
magic strings to indicate a particular vendor, however one of those vendor
names is changed for clarity.

Some points reviewers may want to take notice of:

* Now bzr may try to run whatever is in the BZR_SSH environmental variable.
* Kept the hack added for bug 107155 basically as-is.
* Setting a full path to an ssh client will always auto-detect the vendor by
  running the program with -V and looking at the output string, did not go
  for the BZR_SSH_VENDOR suggestion.
* Not handling unicode paths and environments on win32 so limited to local
  codepage.
* Didn't handle annoying limitation mentioned at:
    <https://answers.launchpad.net/bzr/+question/49961>
  where bzr gives no way to verify the server so it just fails.

Feedback and suggested changes welcome.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_176292.bundle
Type: application/octet-stream
Size: 10779 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090807/bfec4285/attachment-0001.obj