[Success!] Re: [MERGE] Implement bzrlib.lock with CreateFile rather than LockFileEx on win32 (operational part)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin (gzlist) wrote:
...

> In summary:
> * The code is broken on nix.
> * The devs use nix and don't test against other platforms.
> * Therefore, bazaar relies on the code being broken.

Basically, though it is because *in process* locking is not properly
exclusive. It is still properly exclusive *between* processes.

> 
> I could actually submit a patch that cripples write locks in a similar
> way to they are on nix. That seems to fix selftest test_shelf (except
> one symlink test that's lacking a missing feature guard). Whether
> that's actually a good idea or not, is not for me to judge.
> 
> Martin
> 

I did something like that a long time ago, not hard to do as the locking
code is centralized. I just didn't have the time to deal with the
fallout back then.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpNDZUACgkQJdeBCYSNAANZCACaAwaht3hzcww9l79OYEgaFFfa
9UkAnjGWEmYYavvBxoGIMJwdUmF6IjvT
=AERt
-----END PGP SIGNATURE-----