[MERGE] Implement bzrlib.lock with CreateFile rather than LockFileEx on win32 (operational part)
Martin (gzlist)
gzlist at googlemail.com
Thu Jun 25 17:06:55 BST 2009
2009/6/25 John Arbash Meinel <john at arbash-meinel.com>:
>
> I added this NEWS entry, and I wanted to make sure it was correct:
>
> * OS file locks are now taken out using ``CreateFile`` rather than
> ``LockFileEx`` on Windows. The locking remains exclusive with
> ``LockFileEx`` but now it also works on older versions of Windows
> (such as Win98). (Martin <gzlist>)
>
> Does that fit what this patch is about?
Looks good to me, thanks!
Martin
On 25/06/2009, John Arbash Meinel <john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Alexander Belchenko wrote:
>> bb:approve
>>
>> This is definitely improvements: it works fine on all Windows 2K/Xp and
>> Windows 98.
>>
>> I have no Vista to test.
>>
>> John, can you look and approve this patch, please?
>>
>>
>>
>
> I added this NEWS entry, and I wanted to make sure it was correct:
>
> * OS file locks are now taken out using ``CreateFile`` rather than
> ``LockFileEx`` on Windows. The locking remains exclusive with
> ``LockFileEx`` but now it also works on older versions of Windows
> (such as Win98). (Martin <gzlist>)
>
> Does that fit what this patch is about?
>
> John
> =:->
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkpDms8ACgkQJdeBCYSNAAPodQCeNOmJQvp425Ql6NK2WUCg2jNs
> 4t4An0h2JniaA+yvxMNqvC1GJ3gdPX9l
> =QMmx
> -----END PGP SIGNATURE-----
>
>
More information about the bazaar
mailing list