[MERGE] Resume indices before pack files

John Arbash Meinel john at arbash-meinel.com
Tue Jun 23 15:48:45 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is probably just a minor change, but I noticed that ResumedPack has
a slightly different ordering.

When creating a new pack, we:
1) write the content to upload
2) write the indices to indices/*
3) rename upload/foo => packs/bar
4) Finish updating pack-names

In the case of ResumedPack it was doing:

1) (content already in upload)
2) move upload/foo => packs/bar
3) move upload/indices => indices/*
4) finish

This just swaps 2 & 3 to be more consistent with uploading new packs.

I don't think the order matters much, because we either succeed or fail
at everything (or we don't update pack-names). I just felt it was better
to always use the same order.

And Robert has mentioned that the .pack file determines the presence
rather than the index. (Versus .knits where the .kndx was the
all-powerful bit.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpA600ACgkQJdeBCYSNAAP3cACgvxZJAwsQXi5evDh6MuQvc4Lq
1joAnRDYsnWp1U9BFdHQLV3opTfkbMws
=KHvd
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: resumed_index_first.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090623/644af5ec/attachment.diff 


More information about the bazaar mailing list