[MERGE] Exception when pulling from a location

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Going further, if you *can't* connect to the URL why would we want to
> try 2 times? (Which seems to be what you are suggesting.)

Fundamentally, an attempt to read a branch from a URL might succeed
where attempting to read a bundle from the URL would fail.  Also, it's
fewer special cases, so simpler code.

You pitched this as a fix for this problem:

> ... if we got an abort on the connection, we would still
> attempt to re-use the connection to do a later Branch.open()

Which as we know leads to ugly and bad errors.  I attempted to fix them
at the source years ago, but my patch was rejected, and those more
qualified to fix it  still haven't done so.

I would much rather have a fix for those errors, which are a more
general problem.  Pretty please?

> I can understand that Transports should be able to recover from a
> connection failure and try again later. I think it is silly to have a
> command like "bzr push" do it.

If we were repeating the same operation and hoping for different
results, I would agree.  But it's possible that attempting to open a
branch at a URL would succeed where attempting to open a bundle at that
URL would fail.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko73XQACgkQ0F+nu1YWqI3P7gCdG+UymO3cIIiCxkO2oRh34zwo
b90An1A3vh/fR4zWjmy7kVH4clFGrZGl
=f4LZ
-----END PGP SIGNATURE-----