OS locks woes (was: Re: [MERGE] Implement bzrlib.lock with CreateFile rather than LockFileEx on win32 (operational part))

[Martin Pool]

2009/6/19 Alexander Belchenko <bialix at ukr.net>:
> Using this patch from Martin (gzlist) and some small change to the code to
> print filename of OS-locked file (I've did it for testing unicode locking)
> and I found that dirstate locked toooo often in some situations.
>
> May be our dear bzr.devs already know this, but -Dlock does not show this
> kind of info, so I show you my results. As you could see many operations
> lock the dirstate 3-4 and more times. I don't think it's right, especially
> regarding to various OS locks problem on Windows.

I think you're right, that is bad.  -Dlock should report on them, and
we should perhaps add some assertions it does not happen too many
times.



-- 
Martin <http://launchpad.net/~mbp/>