[MERGE] Pass create_prefix paremeter to BzrDir.push_branch.

Ian Clatworthy ian.clatworthy at canonical.com
Thu Jun 11 08:19:10 BST 2009

Ian Clatworthy has voted comment.
Status is now: Semi-approved
I'm not sure about this, despite it being a rather innocent change.

My main concern is that it confuses the layering, i.e. which layer has 
responsibility for creating the prefix. Right now, it's push.py. If we 
add a parameter to the method in bzrdir.py, then arguably the logic 
ought to be moved there rather than be left in push.py? Otherwise, 
there's a parameter there in the bzrdir.py method that we're ignoring 
with no obvious reason as to why.

Maybe there's another way? I'm thinking of a flag saying whether control 
dirs are virtual for a given transport, and using that in push.py to 
decide whether to push down create_prefix or not. I can't say that 
that's necessarily better but I wanted to check that you had ruled it 

For details, see: 
Project: Bazaar

More information about the bazaar mailing list