[MERGE][1.16] Added directory structure and started translation of docs in Russian.
Vincent Ladeuil
v.ladeuil+lp at free.fr
Wed Jun 10 09:47:45 BST 2009
Only minor concerns, mostly I'd like some comments added,
congrats for leading that effort that far already !
BB:tweak
I can't read Russian but I ran the tests and 'make doc' locally,
all went fine, so my review is only about the doc build process.
>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
<snip/>
bialix> === modified file 'Makefile'
bialix> --- Makefile 2009-05-28 18:03:38 +0000
bialix> +++ Makefile 2009-06-09 09:32:12 +0000
bialix> @@ -93,7 +93,11 @@
bialix> $(wildcard doc/es/guia-usario/*.txt) \
bialix> doc/es/mini-tutorial/index.txt \
bialix> doc/index.txt \
bialix> - doc/index.es.txt
bialix> + doc/index.es.txt \
bialix> + doc/index.ru.txt \
bialix> + doc/ru/user-guide/index.txt \
bialix> + doc/ru/mini-tutorial/index.txt \
bialix> + $(wildcard doc/ru/tutorials/*.txt)
bialix> non_txt_files := \
bialix> doc/default.css \
bialix> doc/en/quick-reference/quick-start-summary.svg \
bialix> @@ -103,7 +107,11 @@
bialix> doc/es/referencia-rapida/referencia-rapida.svg \
bialix> doc/es/referencia-rapida/referencia-rapida.png \
bialix> doc/es/referencia-rapida/referencia-rapida.pdf \
bialix> - $(wildcard doc/es/guia-usuario/images/*.png)
bialix> + $(wildcard doc/es/guia-usuario/images/*.png) \
bialix> + doc/ru/quick-reference/quick-start-summary.svg \
bialix> + doc/ru/quick-reference/quick-start-summary.png \
bialix> + doc/ru/quick-reference/quick-start-summary.pdf \
bialix> + $(wildcard doc/ru/user-guide/images/*.png)
bialix> htm_files := $(patsubst %.txt, %.html, $(txt_files))
There are some duplication with the quick-reference/Makefile in
the doc/[es|en|ru] directories.
You don't need to address that, but a comment in the
en/quick-reference/Makefile along the lines:
# If you feel the need to duplicate that file, you'll win the
# right to refactor doc/[en/es/ru]/quick-reference/Makefile and
# update TARGETS and OBJECTS usages in doc/Makefile
will help ensure this duplication is addressed one day :)
bialix> @@ -133,12 +141,13 @@
bialix> dev_txt_files := $(filter-out $(dev_txt_nohtml), $(dev_txt_all))
bialix> dev_htm_files := $(patsubst %.txt, %.html, $(dev_txt_files))
bialix> -doc/en/user-guide/index.html: $(wildcard $(addsuffix /*.txt, doc/en/user-guide))
bialix> - $(rst2html) --stylesheet=../../default.css doc/en/user-guide/index.txt $@
bialix> +doc/%/user-guide/index.html: $(wildcard $(addsuffix /*.txt, doc/%/user-guide))
bialix> + $(rst2html) --stylesheet=../../default.css $(dir $@)index.txt $@
That's the right track.
Vincent
More information about the bazaar
mailing list